[Lldb-commits] [lldb] r236700 - Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError

Ilia K ki.stfu at gmail.com
Wed May 6 23:27:44 PDT 2015


Author: ki.stfu
Date: Thu May  7 01:27:43 2015
New Revision: 236700

URL: http://llvm.org/viewvc/llvm-project?rev=236700&view=rev
Log:
Fix ClangUserExpression::Evaluate return code in case of eExpressionParseError

Summary: This patch fixes retvalue of ClangUserExpression::Evaluate in case of eExpressionParseError error

Reviewers: jingham, spyffe, clayborg

Reviewed By: clayborg

Subscribers: lldb-commits, clayborg, spyffe, jingham

Differential Revision: http://reviews.llvm.org/D9502

Modified:
    lldb/trunk/source/Expression/ClangUserExpression.cpp

Modified: lldb/trunk/source/Expression/ClangUserExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangUserExpression.cpp?rev=236700&r1=236699&r2=236700&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ClangUserExpression.cpp (original)
+++ lldb/trunk/source/Expression/ClangUserExpression.cpp Thu May  7 01:27:43 2015
@@ -1066,10 +1066,11 @@ ClangUserExpression::Evaluate (Execution
                                     keep_expression_in_memory,
                                     generate_debug_info))
     {
+        execution_results = lldb::eExpressionParseError;
         if (error_stream.GetString().empty())
-            error.SetExpressionError (lldb::eExpressionParseError, "expression failed to parse, unknown error");
+            error.SetExpressionError (execution_results, "expression failed to parse, unknown error");
         else
-            error.SetExpressionError (lldb::eExpressionParseError, error_stream.GetString().c_str());
+            error.SetExpressionError (execution_results, error_stream.GetString().c_str());
     }
     else
     {





More information about the lldb-commits mailing list