[Lldb-commits] [lldb] r236259 - Remove the NullLog class introduced in r236174.

[Zachary Turner]

Author: zturner
Date: Thu Apr 30 16:03:37 2015
New Revision: 236259

URL: http://llvm.org/viewvc/llvm-project?rev=236259&view=rev
Log:
Remove the NullLog class introduced in r236174.

Based on list discussions, a different approach is desired for
reducing the visual impact of logging statements on the
readability of the code.  Another mechanism will be added in
a followup patch, but for now, since NullLog is unreferenced,
this patch just removes it.

This patch does *not* remove the other half of r236174, which was
to delete some dead code surrounding logging flags.

Removed:
    lldb/trunk/include/lldb/Core/NullLog.h
    lldb/trunk/source/Core/NullLog.cpp
Modified:
    lldb/trunk/source/Core/CMakeLists.txt

Removed: lldb/trunk/include/lldb/Core/NullLog.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/NullLog.h?rev=236258&view=auto
==============================================================================
--- lldb/trunk/include/lldb/Core/NullLog.h (original)
+++ lldb/trunk/include/lldb/Core/NullLog.h (removed)
@@ -1,58 +0,0 @@
-//===-- NullLog.h -----------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef liblldb_Core_NullLog_H_
-#define liblldb_Core_NullLog_H_
-
-#include "lldb/Core/Log.h"
-
-//----------------------------------------------------------------------
-// Logging Functions
-//----------------------------------------------------------------------
-namespace lldb_private
-{
-
-class NullLog : public Log
-{
-    NullLog(NullLog &) = delete;
-    NullLog &operator=(NullLog &) = delete;
-
-  public:
-    //------------------------------------------------------------------
-    // Member functions
-    //------------------------------------------------------------------
-    NullLog();
-    ~NullLog();
-
-    void PutCString(const char *cstr) override;
-
-    void Printf(const char *format, ...) override __attribute__((format(printf, 2, 3)));
-
-    void VAPrintf(const char *format, va_list args) override;
-
-    void LogIf(uint32_t mask, const char *fmt, ...) override __attribute__((format(printf, 3, 4)));
-
-    void Debug(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-
-    void DebugVerbose(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-
-    void Error(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-
-    void FatalError(int err, const char *fmt, ...) override __attribute__((format(printf, 3, 4)));
-
-    void Verbose(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-
-    void Warning(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-
-    void WarningVerbose(const char *fmt, ...) override __attribute__((format(printf, 2, 3)));
-};
-
-} // namespace lldb_private
-
-#endif // liblldb_Core_NullLog_H_

Modified: lldb/trunk/source/Core/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/CMakeLists.txt?rev=236259&r1=236258&r2=236259&view=diff
==============================================================================
--- lldb/trunk/source/Core/CMakeLists.txt (original)
+++ lldb/trunk/source/Core/CMakeLists.txt Thu Apr 30 16:03:37 2015
@@ -38,7 +38,6 @@ add_lldb_library(lldbCore
   Module.cpp
   ModuleChild.cpp
   ModuleList.cpp
-  NullLog.cpp
   Opcode.cpp
   PluginManager.cpp
   RegisterValue.cpp

Removed: lldb/trunk/source/Core/NullLog.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/NullLog.cpp?rev=236258&view=auto
==============================================================================
--- lldb/trunk/source/Core/NullLog.cpp (original)
+++ lldb/trunk/source/Core/NullLog.cpp (removed)
@@ -1,74 +0,0 @@
-//===-- NullLog.cpp ---------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "lldb/Core/NullLog.h"
-
-using namespace lldb_private;
-
-NullLog::NullLog()
-{
-}
-NullLog::~NullLog()
-{
-}
-
-void
-NullLog::PutCString(const char *cstr)
-{
-}
-
-void
-NullLog::Printf(const char *format, ...)
-{
-}
-
-void
-NullLog::VAPrintf(const char *format, va_list args)
-{
-}
-
-void
-NullLog::LogIf(uint32_t mask, const char *fmt, ...)
-{
-}
-
-void
-NullLog::Debug(const char *fmt, ...)
-{
-}
-
-void
-NullLog::DebugVerbose(const char *fmt, ...)
-{
-}
-
-void
-NullLog::Error(const char *fmt, ...)
-{
-}
-
-void
-NullLog::FatalError(int err, const char *fmt, ...)
-{
-}
-
-void
-NullLog::Verbose(const char *fmt, ...)
-{
-}
-
-void
-NullLog::Warning(const char *fmt, ...)
-{
-}
-
-void
-NullLog::WarningVerbose(const char *fmt, ...)
-{
-}