[Lldb-commits] [lldb] r235584 - Fix test expectation in TestNoreturnUnwind

[Tamas Berghammer]

Author: tberghammer
Date: Thu Apr 23 05:54:27 2015
New Revision: 235584

URL: http://llvm.org/viewvc/llvm-project?rev=235584&view=rev
Log:
Fix test expectation in TestNoreturnUnwind

The test case lookinhg for the abort function in the stack trace.
Previously it lookd for a function which ends with "abort" but on some
system there are multiple such functions (e.g.: on android abort calls
__libc_android_abort) what made the test fail. This CL change the
behaviour to look for the abort function based on a fix list of names.

Modified:
    lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py

Modified: lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py?rev=235584&r1=235583&r2=235584&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py (original)
+++ lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py Thu Apr 23 05:54:27 2015
@@ -45,9 +45,8 @@ class NoreturnUnwind(TestBase):
         thread = process.GetThreadAtIndex(0)
         abort_frame_number = 0
         for f in thread.frames:
-            # We use endswith() to look for abort() since some C libraries mangle the symbol into
-            # __GI_abort or similar.
-            if f.GetFunctionName().endswith("abort"):
+            # Some C libraries mangle the abort symbol into __GI_abort.
+            if f.GetFunctionName() in ["abort", "__GI_abort"]:
                 break
             abort_frame_number = abort_frame_number + 1