[Lldb-commits] [PATCH] LLDB qXfer:features:read support

[Greg Clayton]

A few things to fix:

- remove the unused ePropertyGdbServerCompatibility enum
- Use StringStream instead of std::stringstream to keep things consistent with all other send packets

This:

+    // build the qSupported packet
+    std::vector<std::string> features = {"xmlRegisters=i386,arm,mips"};
+    std::stringstream packet;
+    packet << "qSupported";
+    for ( uint32_t i = 0; i < features.size( ); i++ )
+        packet << (i==0 ? ":" : ";") << features[i];

can become

std::vector<std::string> features = {"xmlRegisters=i386,arm,mips"};
StringStream packet;
packet.PutCString("qSupported");
for (const auto& feature: features)
{
    packet.Printf("%c%s", (i==0 ? ':' : ';'), feature.c_str());
}

> On Apr 14, 2015, at 9:17 AM, Aidan Dodds <aidan at codeplay.com> wrote:
> 
> Thanks for having a look at my previous patch Greg.  I have made a revision that hopefully addresses all the points you had raised earlier.  Any other C&C is welcome.
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D8999
> 
> Files:
>  cmake/modules/LLDBConfig.cmake
>  source/Commands/CommandObjectRegister.cpp
>  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
>  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
>  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
>  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D8999.23736.patch>