[Lldb-commits] [Diffusion] rL234514: Fix @skipUnlessPlatform and @skipIfPlatform decorators to work on classes.

[Ilia K]

Hello @flackr,

The 6 tests started failing on OS X since this commit:

  ======================================================================
  FAIL: test_break_with_dsym (TestRuntimeTypes.RuntimeTypesTestCase)
     Test setting objc breakpoints using '_regexp-break' and 'breakpoint set'.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 462, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestRuntimeTypes.py", line 22, in test_break_with_dsym
      self.runtime_types()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestRuntimeTypes.py", line 56, in runtime_types
      substrs = ["foo"])
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2157, in expect
      msg if msg else EXP_MSG(str, exe))
  AssertionError: False is not True : Variable(s) displayed correctly
  Config=x86_64-clang
  ======================================================================
  FAIL: test_break_with_dwarf (TestRuntimeTypes.RuntimeTypesTestCase)
     Test setting objc breakpoints using '_regexp-break' and 'breakpoint set'.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 479, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestRuntimeTypes.py", line 30, in test_break_with_dwarf
      self.runtime_types()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestRuntimeTypes.py", line 56, in runtime_types
      substrs = ["foo"])
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2157, in expect
      msg if msg else EXP_MSG(str, exe))
  AssertionError: False is not True : Variable(s) displayed correctly
  Config=x86_64-clang
  ----------------------------------------------------------------------
  ======================================================================
  FAIL: test_break_with_dsym (TestConstStrings.ConstStringTestCase)
     Test constant string generation amd comparison by the expression parser.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 462, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestConstStrings.py", line 23, in test_break_with_dsym
      self.objc_const_strings()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestConstStrings.py", line 52, in objc_const_strings
      startstr = "(int) $0 = 0")
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2093, in expect
      self.runCmd(str, msg=msg, trace = (True if trace else False), check = not error, inHistory=inHistory)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2019, in runCmd
      msg if msg else CMD_MSG(cmd))
  AssertionError: False is not True : Command 'expression (int)[str compare:@"hello"]' returns successfully
  Config=x86_64-clang
  ======================================================================
  FAIL: test_break_with_dwarf (TestConstStrings.ConstStringTestCase)
     Test constant string generation amd comparison by the expression parser.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 479, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestConstStrings.py", line 30, in test_break_with_dwarf
      self.objc_const_strings()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestConstStrings.py", line 52, in objc_const_strings
      startstr = "(int) $0 = 0")
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2093, in expect
      self.runCmd(str, msg=msg, trace = (True if trace else False), check = not error, inHistory=inHistory)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2019, in runCmd
      msg if msg else CMD_MSG(cmd))
  AssertionError: False is not True : Command 'expression (int)[str compare:@"hello"]' returns successfully
  Config=x86_64-clang
  ----------------------------------------------------------------------
  ======================================================================
  FAIL: test_NSError_po_with_dsym (TestObjCMethods2.FoundationTestCase2)
      Test that po of the result of an unknown method doesn't require a cast.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 543, in wrapper
      func(*args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 462, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestObjCMethods2.py", line 69, in test_NSError_po_with_dsym
      self.NSError_po()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestObjCMethods2.py", line 216, in NSError_po
      substrs = ["Error Domain=Hello", "Code=35", "be completed."])
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2157, in expect
      msg if msg else EXP_MSG(str, exe))
  AssertionError: False is not True : 'Error Domain=Hello' returns expected result
  Config=x86_64-clang
  ======================================================================
  FAIL: test_NSError_po_with_dwarf (TestObjCMethods2.FoundationTestCase2)
      Test that po of the result of an unknown method doesn't require a cast.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 543, in wrapper
      func(*args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 479, in wrapper
      return func(self, *args, **kwargs)
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestObjCMethods2.py", line 76, in test_NSError_po_with_dwarf
      self.NSError_po()
    File "/Users/IliaK/p/llvm/tools/lldb/test/lang/objc/foundation/TestObjCMethods2.py", line 216, in NSError_po
      substrs = ["Error Domain=Hello", "Code=35", "be completed."])
    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2157, in expect
      msg if msg else EXP_MSG(str, exe))
  AssertionError: False is not True : 'Error Domain=Hello' returns expected result
  Config=x86_64-clang
  ----------------------------------------------------------------------

Take a look please.

Thanks,
Ilia


USERS
  flackr (Author)

http://reviews.llvm.org/rL234514

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/