[Lldb-commits] [PATCH] Skip tests that are failed on linux with gcc-4.9.2

[Pavel Labath]

Slightly off topic, but I would like to ask what is the guideline for
using skipIf vs. expectedFailure? Do we have one? (If not maybe we
should make one)

I was under the impression that expectedFailureXXX is to be used for
tests that are failing due to a bug in LLDB, whereas skipIfXXX are for
situations where the test simply does not apply to the platform
environment in question (e.g. debugserver tests on linux, etc). If
that is the case, then these tests should be XFAILed rather then
skipped.
Is that so ?

For the readability issue, I would propose the following syntax:

@skipIf("bugnumber", lambda x: compilerIs("gcc>=4.9") &&
platformIs("linux") && architectureIs("aarch64", "x86_64"))

I think this would be more versatile that the previous solutions, and
you don't need to litter the code with so many decorators.
What do you think about that?

cheers,
pl


http://reviews.llvm.org/D8851

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/