[Lldb-commits] [lldb] r234539 - Don't hardcode the name of the plugin - or it will get out of date, and this code will be broken

Enrico Granata egranata at apple.com
Thu Apr 9 14:52:19 PDT 2015


Author: enrico
Date: Thu Apr  9 16:52:19 2015
New Revision: 234539

URL: http://llvm.org/viewvc/llvm-project?rev=234539&view=rev
Log:
Don't hardcode the name of the plugin - or it will get out of date, and this code will be broken

Thanks Greg!


Modified:
    lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp?rev=234539&r1=234538&r2=234539&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp (original)
+++ lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Thu Apr  9 16:52:19 2015
@@ -53,6 +53,8 @@
 #include "clang/AST/ASTContext.h"
 #include "clang/AST/DeclObjC.h"
 
+#include "Plugins/Platform/MacOSX/PlatformiOSSimulator.h"
+
 #include <vector>
 
 using namespace lldb;
@@ -1578,11 +1580,9 @@ AppleObjCRuntimeV2::WarnIfNoClassesCache
     if (m_noclasses_warning_emitted)
         return;
     
-    static ConstString g_ios_simulator("ios-simulator");
-    
     if (m_process &&
         m_process->GetTarget().GetPlatform() &&
-        m_process->GetTarget().GetPlatform()->GetPluginName() == g_ios_simulator)
+        m_process->GetTarget().GetPlatform()->GetPluginName() == PlatformiOSSimulator::GetPluginNameStatic())
     {
         // the iOS simulator does not have the objc_opt_ro class table
         // so don't actually complain to the user





More information about the lldb-commits mailing list