[Lldb-commits] [PATCH] Skip tests that are failed on linux with gcc-4.9.2

[Siva Chandra]

================
Comment at: test/lldbtest.py:740
@@ +739,3 @@
+
+def skipIfPlatformCompiler(bugnumber=None, platform=None, compiler=None, compiler_version=None, archs=None):
+    def fn(self):
----------------
Could we just name this function "skipIf" and use it directly to decorate tests? May be we could eliminate all skipIf* decorators in favor of this, but I have not thought through that thoroughly. Atleast, it seems to me that things like skipIfLinuxGcc, skipIfGcc and skipIfClang can be eliminated. You will ofcourse have to change the logic in the 'fn' function below. And ofcourse you need not have to remove/modify the existing decorators in this patch itself.

One thing we might loose is the ability to "git grep xxx" to get all tests decorated with xxx.

http://reviews.llvm.org/D8851

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/