[Lldb-commits] [lldb] r234422 - Remove redundant virtual for member functions marked 'override'.
David Blaikie
dblaikie at gmail.com
Wed Apr 8 10:22:10 PDT 2015
Author: dblaikie
Date: Wed Apr 8 12:22:09 2015
New Revision: 234422
URL: http://llvm.org/viewvc/llvm-project?rev=234422&view=rev
Log:
Remove redundant virtual for member functions marked 'override'.
Modified:
lldb/trunk/include/lldb/Interpreter/ScriptInterpreterPython.h
lldb/trunk/include/lldb/Symbol/ClangExternalASTSourceCallbacks.h
lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
lldb/trunk/source/Plugins/Process/Windows/DynamicLoaderWindows.h
lldb/trunk/source/Plugins/Process/Windows/LocalDebugDelegate.h
lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h
Modified: lldb/trunk/include/lldb/Interpreter/ScriptInterpreterPython.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Interpreter/ScriptInterpreterPython.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Interpreter/ScriptInterpreterPython.h (original)
+++ lldb/trunk/include/lldb/Interpreter/ScriptInterpreterPython.h Wed Apr 8 12:22:09 2015
@@ -346,10 +346,9 @@ public:
StringList
ReadCommandInputFromUser (FILE *in_file);
-
- virtual void
- ResetOutputFileHandle (FILE *new_fh) override;
-
+
+ void ResetOutputFileHandle(FILE *new_fh) override;
+
static void
InitializePrivate ();
Modified: lldb/trunk/include/lldb/Symbol/ClangExternalASTSourceCallbacks.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Symbol/ClangExternalASTSourceCallbacks.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Symbol/ClangExternalASTSourceCallbacks.h (original)
+++ lldb/trunk/include/lldb/Symbol/ClangExternalASTSourceCallbacks.h Wed Apr 8 12:22:09 2015
@@ -100,7 +100,7 @@ public:
return;
}
- virtual clang::ExternalLoadResult
+ clang::ExternalLoadResult
FindExternalLexicalDecls(const clang::DeclContext *decl_ctx, bool (*isKindWeWant)(clang::Decl::Kind),
llvm::SmallVectorImpl<clang::Decl *> &decls) override
{
@@ -109,12 +109,11 @@ public:
return clang::ELR_Failure;
}
- virtual bool FindExternalVisibleDeclsByName(const clang::DeclContext *decl_ctx,
- clang::DeclarationName decl_name) override;
+ bool FindExternalVisibleDeclsByName(const clang::DeclContext *decl_ctx, clang::DeclarationName decl_name) override;
- virtual void CompleteType(clang::TagDecl *tag_decl) override;
+ void CompleteType(clang::TagDecl *tag_decl) override;
- virtual void CompleteType(clang::ObjCInterfaceDecl *objc_decl) override;
+ void CompleteType(clang::ObjCInterfaceDecl *objc_decl) override;
bool layoutRecordType(const clang::RecordDecl *Record, uint64_t &Size, uint64_t &Alignment,
llvm::DenseMap<const clang::FieldDecl *, uint64_t> &FieldOffsets,
Modified: lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.h (original)
+++ lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.h Wed Apr 8 12:22:09 2015
@@ -45,10 +45,9 @@ namespace lldb_private {
static const char *
GetPluginDescriptionStatic (bool is_host);
- virtual lldb_private::ConstString
- GetPluginName() override;
-
- virtual uint32_t
+ lldb_private::ConstString GetPluginName() override;
+
+ uint32_t
GetPluginVersion() override
{
return 1;
@@ -57,50 +56,38 @@ namespace lldb_private {
//------------------------------------------------------------
// lldb_private::Platform functions
//------------------------------------------------------------
- virtual Error
- ResolveExecutable (const lldb_private::ModuleSpec &module_spec,
- lldb::ModuleSP &module_sp,
- const FileSpecList *module_search_paths_ptr) override;
+ Error ResolveExecutable(const lldb_private::ModuleSpec &module_spec, lldb::ModuleSP &module_sp,
+ const FileSpecList *module_search_paths_ptr) override;
- virtual const char *
- GetDescription () override
+ const char *
+ GetDescription() override
{
return GetPluginDescriptionStatic(IsHost());
}
- virtual void
- GetStatus (Stream &strm) override;
+ void GetStatus(Stream &strm) override;
- virtual Error
- GetFileWithUUID (const FileSpec &platform_file,
- const UUID* uuid, FileSpec &local_file) override;
+ Error GetFileWithUUID(const FileSpec &platform_file, const UUID *uuid, FileSpec &local_file) override;
- virtual bool
- GetProcessInfo (lldb::pid_t pid, ProcessInstanceInfo &proc_info) override;
+ bool GetProcessInfo(lldb::pid_t pid, ProcessInstanceInfo &proc_info) override;
- virtual bool
- GetSupportedArchitectureAtIndex (uint32_t idx, ArchSpec &arch) override;
+ bool GetSupportedArchitectureAtIndex(uint32_t idx, ArchSpec &arch) override;
- virtual size_t
- GetSoftwareBreakpointTrapOpcode (Target &target,
- BreakpointSite *bp_site) override;
+ size_t GetSoftwareBreakpointTrapOpcode(Target &target, BreakpointSite *bp_site) override;
- virtual lldb_private::Error
- LaunchProcess (lldb_private::ProcessLaunchInfo &launch_info) override;
+ lldb_private::Error LaunchProcess(lldb_private::ProcessLaunchInfo &launch_info) override;
- virtual lldb::ProcessSP
- Attach(ProcessAttachInfo &attach_info, Debugger &debugger,
- Target *target, Error &error) override;
+ lldb::ProcessSP Attach(ProcessAttachInfo &attach_info, Debugger &debugger, Target *target,
+ Error &error) override;
// Kalimba processes can not be launched by spawning and attaching.
- virtual bool
- CanDebugProcess () override
+ bool
+ CanDebugProcess() override
{
return false;
}
- virtual void
- CalculateTrapHandlerSymbolNames () override;
+ void CalculateTrapHandlerSymbolNames() override;
Error
LaunchNativeProcess (
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h Wed Apr 8 12:22:09 2015
@@ -65,7 +65,7 @@ public:
return GetPluginNameStatic();
}
- virtual uint32_t
+ uint32_t
GetPluginVersion() override
{
return 1;
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h Wed Apr 8 12:22:09 2015
@@ -91,14 +91,11 @@ public:
GetFileWithUUID (const lldb_private::FileSpec &platform_file,
const lldb_private::UUID *uuid_ptr,
lldb_private::FileSpec &local_file) override;
-
- virtual bool
- GetSupportedArchitectureAtIndex (uint32_t idx,
- lldb_private::ArchSpec &arch) override;
- virtual lldb_private::ConstString
- GetSDKDirectory (lldb_private::Target &target) override;
-
+ bool GetSupportedArchitectureAtIndex(uint32_t idx, lldb_private::ArchSpec &arch) override;
+
+ lldb_private::ConstString GetSDKDirectory(lldb_private::Target &target) override;
+
void
AddClangModuleCompilationOptions (lldb_private::Target *target, std::vector<std::string> &options) override
{
Modified: lldb/trunk/source/Plugins/Process/Windows/DynamicLoaderWindows.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Windows/DynamicLoaderWindows.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Windows/DynamicLoaderWindows.h (original)
+++ lldb/trunk/source/Plugins/Process/Windows/DynamicLoaderWindows.h Wed Apr 8 12:22:09 2015
@@ -34,10 +34,10 @@ class DynamicLoaderWindows : public Dyna
Error CanLoadImage () override;
lldb::ThreadPlanSP GetStepThroughTrampolinePlan(Thread &thread, bool stop) override;
- virtual ConstString GetPluginName() override;
- virtual uint32_t GetPluginVersion() override;
+ ConstString GetPluginName() override;
+ uint32_t GetPluginVersion() override;
};
}
-#endif
\ No newline at end of file
+#endif
Modified: lldb/trunk/source/Plugins/Process/Windows/LocalDebugDelegate.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Windows/LocalDebugDelegate.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Windows/LocalDebugDelegate.h (original)
+++ lldb/trunk/source/Plugins/Process/Windows/LocalDebugDelegate.h Wed Apr 8 12:22:09 2015
@@ -42,15 +42,15 @@ class LocalDebugDelegate : public IDebug
public:
explicit LocalDebugDelegate(lldb::ProcessSP process);
- virtual void OnExitProcess(uint32_t exit_code) override;
- virtual void OnDebuggerConnected(lldb::addr_t image_base) override;
- virtual ExceptionResult OnDebugException(bool first_chance, const ExceptionRecord &record) override;
- virtual void OnCreateThread(const HostThread &thread) override;
- virtual void OnExitThread(const HostThread &thread) override;
- virtual void OnLoadDll(const lldb_private::ModuleSpec &module_spec, lldb::addr_t module_addr) override;
- virtual void OnUnloadDll(lldb::addr_t module_addr) override;
- virtual void OnDebugString(const std::string &message) override;
- virtual void OnDebuggerError(const Error &error, uint32_t type) override;
+ void OnExitProcess(uint32_t exit_code) override;
+ void OnDebuggerConnected(lldb::addr_t image_base) override;
+ ExceptionResult OnDebugException(bool first_chance, const ExceptionRecord &record) override;
+ void OnCreateThread(const HostThread &thread) override;
+ void OnExitThread(const HostThread &thread) override;
+ void OnLoadDll(const lldb_private::ModuleSpec &module_spec, lldb::addr_t module_addr) override;
+ void OnUnloadDll(lldb::addr_t module_addr) override;
+ void OnDebugString(const std::string &message) override;
+ void OnDebuggerError(const Error &error, uint32_t type) override;
private:
lldb::ProcessSP m_process;
Modified: lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h?rev=234422&r1=234421&r2=234422&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h (original)
+++ lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.h Wed Apr 8 12:22:09 2015
@@ -66,54 +66,42 @@ public:
//------------------------------------------------------------------
// Check if a given Process
//------------------------------------------------------------------
- virtual bool
- CanDebug (lldb_private::Target &target,
- bool plugin_specified_by_name) override;
+ bool CanDebug(lldb_private::Target &target, bool plugin_specified_by_name) override;
//------------------------------------------------------------------
// Creating a new process, or attaching to an existing one
//------------------------------------------------------------------
- virtual lldb_private::Error
- DoLoadCore () override;
+ lldb_private::Error DoLoadCore() override;
- virtual lldb_private::DynamicLoader *
- GetDynamicLoader () override;
+ lldb_private::DynamicLoader *GetDynamicLoader() override;
//------------------------------------------------------------------
// PluginInterface protocol
//------------------------------------------------------------------
- virtual lldb_private::ConstString
- GetPluginName() override;
+ lldb_private::ConstString GetPluginName() override;
- virtual uint32_t
- GetPluginVersion() override;
+ uint32_t GetPluginVersion() override;
//------------------------------------------------------------------
// Process Control
//------------------------------------------------------------------
- virtual lldb_private::Error
- DoDestroy () override;
+ lldb_private::Error DoDestroy() override;
- virtual void
- RefreshStateAfterStop() override;
+ void RefreshStateAfterStop() override;
//------------------------------------------------------------------
// Process Queries
//------------------------------------------------------------------
- virtual bool
- IsAlive () override;
+ bool IsAlive() override;
//------------------------------------------------------------------
// Process Memory
//------------------------------------------------------------------
- virtual size_t
- ReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
+ size_t ReadMemory(lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
- virtual size_t
- DoReadMemory (lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
+ size_t DoReadMemory(lldb::addr_t addr, void *buf, size_t size, lldb_private::Error &error) override;
- virtual lldb::addr_t
- GetImageInfoAddress () override;
+ lldb::addr_t GetImageInfoAddress() override;
lldb_private::ArchSpec
GetArchitecture();
@@ -126,9 +114,8 @@ protected:
void
Clear ( );
- virtual bool
- UpdateThreadList (lldb_private::ThreadList &old_thread_list,
- lldb_private::ThreadList &new_thread_list) override;
+ bool UpdateThreadList(lldb_private::ThreadList &old_thread_list,
+ lldb_private::ThreadList &new_thread_list) override;
private:
//------------------------------------------------------------------
More information about the lldb-commits
mailing list