[Lldb-commits] [Diffusion] rL233547: Replace sys.platform skips in tests with @skip decorators which check against…

Ilia K ki.stfu at gmail.com
Tue Apr 7 22:49:30 PDT 2015


In http://reviews.llvm.org/D8665#152923, @dawn wrote:

> This change (committed in rev.233547) caused many tests to no longer run on our OSX Jenkins build.  Since we check that a minimum number of tests run, our build is now failing.  We run the tests using:
>
>   ./dosep.py --options "-v --executable $INSTALLDIR/bin/lldb" 2>&1 | tee $INSTALLDIR/test_out.log || true
>
> Tests which used to run (like test_NSString_expr_commands_with_dwarf (TestObjCMethods2.FoundationTestCase2) and 11 other tests in that same file) aren't reported as skipped - they are simply absent from the log.  
>  Please rework this patch?  Thank you.


Thanks for catching. I'll take a look at it today.


USERS
  flackr (Author)

http://reviews.llvm.org/rL233547

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list