[Lldb-commits] [PATCH] [IRForTarget] Strenghten handling of alternate mangling.

[Siva Chandra]

On Tue, Apr 7, 2015 at 10:33 AM, Sean Callanan <scallanan at apple.com> wrote:
> Siva,
>
> two things:
>
> the reason I prefer to have it return a vector is that we could have a
> variety of problems, e.g. missing “const” in the debug info, and I don’t
> want to have special-casing everywhere for each one.

Ah, ok. Got it.

> I just noticed that in your suggestion ("Is it more meaningful this way”)
> you dropped the reference off the std::vector<ConstString> – it should
> definitely be passed in by reference.

That was a slip from my side. Will make it a reference argument in the
new version of the patch.

Thanks for clarifying.