[Lldb-commits] [PATCH] [IRForTarget] Strenghten handling of alternate mangling.

[Sean Callanan]

I like this; we could have the CXXLanguageRuntime return a list of “candidate” remangled names if you can’t find a given one, and then try those.
The function would have the signature

size_t
CXXLanguageRuntime::GetAlternateManglings(ConstString mangled_name, std::vector<ConstString> &alternate_names);

What do you folks think?

Sean

Siva, please move your logic (and the existing logic) into that function, which should ideally just take a str

> On Apr 6, 2015, at 3:15 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Is it possible to do away with the hardcoded mangled name?  I really dislike seeing this kind of thing.  Not only because it doesn't work with all ABIs, but just in general it's very gross for the debugger to have exceptions for specific mangled names.  Why is this necessary, and is there any way to get rid of it?
> 
> If it is necessary, can we at least move it to somewhere more appropriate like the Mangled class and provide some kind of generic method like Mangled::GetAlternateMangling()?  
> 
> On Mon, Apr 6, 2015 at 3:10 PM Greg Clayton <clayborg at gmail.com <mailto:clayborg at gmail.com>> wrote:
> I'll OK this on the condition that Sean Callanan OKs this. Sean?
> 
> 
> http://reviews.llvm.org/D8846 <http://reviews.llvm.org/D8846>
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/ <http://reviews.llvm.org/settings/panel/emailpreferences/>
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu <mailto:lldb-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150406/49b75c66/attachment.html>