[Lldb-commits] [PATCH] Introduce a TypeSystem interface to support adding non-clang languages.

[Ryan Brown]

I think I've addressed most of your comments, except removing more methods from TypeSystem.h. I've added TODOs for the methods I think should be removed, and the ones I'm unsure about.
I've also changed the style for the ClangASTContext specific methods.
Instead of ast->Foo(type.GetOpaqueQualType()), it's now ClangASTContext::Foo(type). I think this is cleaner and safer.
If you like this style and agree on which methods to keep I'll go ahead and move the methods.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8712

Files:
  include/lldb/Symbol/ClangASTContext.h
  include/lldb/Symbol/ClangASTType.h
  include/lldb/Symbol/TaggedASTType.h
  include/lldb/Symbol/Type.h
  include/lldb/Symbol/TypeSystem.h
  include/lldb/lldb-forward.h
  lldb.xcodeproj/project.pbxproj
  source/API/SBType.cpp
  source/Commands/CommandObjectMemory.cpp
  source/Core/ValueObjectMemory.cpp
  source/DataFormatters/CXXFormatterFunctions.cpp
  source/DataFormatters/CoreMedia.cpp
  source/DataFormatters/LibCxxMap.cpp
  source/DataFormatters/NSArray.cpp
  source/DataFormatters/NSDictionary.cpp
  source/DataFormatters/NSIndexPath.cpp
  source/DataFormatters/VectorType.cpp
  source/Expression/ASTDumper.cpp
  source/Expression/ClangASTSource.cpp
  source/Expression/ClangExpressionDeclMap.cpp
  source/Expression/IRForTarget.cpp
  source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp
  source/Symbol/CMakeLists.txt
  source/Symbol/ClangASTContext.cpp
  source/Symbol/ClangASTType.cpp
  source/Symbol/Type.cpp
  source/Symbol/TypeSystem.cpp
  source/Target/ObjCLanguageRuntime.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8712.23189.patch
Type: text/x-patch
Size: 770008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150403/6f435a8b/attachment.bin>