[Lldb-commits] [PATCH] Fix test expectation for aarch64 in several test case

[Oleksiy Vyalov]

Please see my comments.


================
Comment at: test/lldbplatformutil.py:1
@@ +1,2 @@
+""" This modul contains functions used by the test cases to hide the
+architecture and/or the platform dependent nature of the tests. """
----------------
s/modul/module

================
Comment at: test/lldbplatformutil.py:4
@@ +3,3 @@
+
+def check_first_register_readable(self):
+    if self.getArchitecture() in ['x86_64', 'i386']:
----------------
self argument looks a little awkward here since there is no class around - maybe use test_case instead of self? 

================
Comment at: test/lldbplatformutil.py:4
@@ +3,3 @@
+
+def check_first_register_readable(self):
+    if self.getArchitecture() in ['x86_64', 'i386']:
----------------
ovyalov wrote:
> self argument looks a little awkward here since there is no class around - maybe use test_case instead of self? 
Since this function depends on methods and data from lldbtest what do you think about moving it into lldbtest.py?

http://reviews.llvm.org/D8702

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/