[Lldb-commits] [PATCH] Update sys.platform switched behavior in tests to use self.getPlatform (remote target platform)

[Ed Maste]

lgtm


REPOSITORY
  rL LLVM

================
Comment at: test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py:218
@@ -217,3 +217,3 @@
 
-        if not(sys.platform.startswith("darwin")): # if stopped, we will have a process around
+        if not(self.getPlatform() == "darwin"): # if stopped, we will have a process around
             self.expect("thread list", error=True,substrs = ['Process must be launched'])
----------------
should we change these cases to be `if (self.getPlatform() != "darwin")`?

================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:41
@@ -40,3 +40,3 @@
 
-        if sys.platform.startswith("darwin"):
+        if self.getPlatform() == "darwin":
             dylibName = 'libloadunload_d.dylib'
----------------
Independent of this change, seems like this test would benefit from a little refactoring

================
Comment at: test/functionalities/register/TestRegisters.py:92
@@ -91,3 +91,3 @@
         self.platform = ""
-        if sys.platform.startswith("darwin"):
+        if self.getPlatform() == "darwin":
             self.platform = "" # TODO: add support for "log enable darwin registers"
----------------
same comment about refactoring

http://reviews.llvm.org/D8747

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/