[Lldb-commits] [PATCH] Fix test expectation for aarch64 in several test case

[Oleksiy Vyalov]

Please see my comments.


================
Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:98
@@ -97,1 +97,3 @@
 
+    def check_register_read_working(self):
+        if self.getArchitecture() in ['x86_64', 'i386']:
----------------
omjavaid wrote:
> Hi Tamas,
> 
> Can we put this function in one place and use it from there instead on duplicating it in every other file?
> 
> In my opinion we should consider separating such tests by architecture and put them in a library or file that can imported otherwise these will be very hard to maintain as our test set grows large.
+1

================
Comment at: test/functionalities/inferior-assert/TestInferiorAssert.py:105
@@ +104,3 @@
+            # TODO: Add check for other architectures
+            self.fail("Unsupported architecture for test case")
+
----------------
Could you print here self.getArchitecture()?

http://reviews.llvm.org/D8702

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/