[Lldb-commits] [PATCH] Allow multiple simultaneous connections to lldb-platform

Robert Flack flackr at gmail.com
Mon Mar 30 07:30:53 PDT 2015


================
Comment at: include/lldb/Host/Socket.h:64
@@ -60,1 +63,3 @@
+        Predicate<uint16_t>* predicate,
+        int backlog = 5);
     static Error TcpConnect(llvm::StringRef host_and_port, bool child_processes_inherit, Socket *&socket);
----------------
tberghammer wrote:
> I think you should leave the default value to be 1 unless you are sure nobody is depending on the original behavior.
I agree, especially since the way this is used in ConnectionFileDescriptorPosix only accepts 1 connection.

http://reviews.llvm.org/D8696

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list