[Lldb-commits] [PATCH] TestConvenienceVariables - fixed a Linux problem

[Siva Chandra]

LGTM.
One nit which you can choose to ignore.


================
Comment at: test/functionalities/embedded_interpreter/TestConvenienceVariables.py:84
@@ -82,3 +83,3 @@
         self.expect(child.before, exe=False,
-            patterns = ['thread #1: tid = 0x[0-9a-f]+, 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d, queue = \'.+\', stop reason = breakpoint 1\.1' % self.line])
+            patterns = ['thread #1: tid = (0x[0-9a-f]+|[0-9]+), 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d, (name|queue) = \'.+\', stop reason = breakpoint 1\.1' % self.line])
 
----------------
Nit: I don't like the readability of this line. May be:

    patterns=['thread #1: tid = (0x[0-9a-f]+|[0-9]+), 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ ' +
              'at main\.c:' + str(self.line) + ',' +
              '(name|queue) = \'.+\', stop reason = breakpoint 1\.1']

http://reviews.llvm.org/D8679

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/