[Lldb-commits] [PATCH] Fix expression evaluation with logs (step + verbose) enabled.

Chaoren Lin chaorenl at google.com
Thu Mar 26 15:24:34 PDT 2015


> all ReportRegisterState does is pretty print its register context


If I invalidate the registers (specifically up to 67) after reading them
then the problem goes away. If I understand correctly, the registers should
be invalidated after every new process_stop_id right? I find it strange
that the StopInfoThreadPlan would be handled in a different process_stop_id
than the one in which the ThreadPlanCallFunction is popped.

The comments on StopInfo::ShouldStop says:

> The ShouldStop method should not do anything that might run code.


Could this have anything to do with it? I tried caching the ShouldStop
value in PerformAction, but the problem still happens.

And anyway, this code only does anything at all if the Expression log is on

> and in verbose mode.  Did you have that log on?


Yeah, the error only happens with logging on.


http://reviews.llvm.org/D8643

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list