[Lldb-commits] [PATCH] Force iteration over FieldDecls and RecordDecls in deterministic order.

[Zachary Turner]

I talked to some of the clang guys here and they said to go back to
DenseMaps to conform to the ExternalASTSource interface, but make sure you
iterate over fields and bases in offset order, which means sorting the list
before doing the insertion.  So I will submit a patch to do that today.

On Tue, Mar 24, 2015 at 10:39 AM Zachary Turner <zturner at google.com> wrote:

> I see what you mean about the interface. I guess that settles that then,
> the interface needs to be consistent. I'll add override keywords so the
> compiler can catch that for me in the future.
>
> But our implementation still needs to add fields in the correct order, so
> iterating over the DenseMap is still not the right approach
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D8512
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150324/b4eba2f0/attachment.html>