[Lldb-commits] [PATCH] Use eFlagRequiresFrame instead of manually checking in CommandObjectThread.cpp.

Jim Ingham jingham at apple.com
Tue Mar 24 10:48:00 PDT 2015


The only thing that bothers me a bit about this patch is that somebody might think we need to go clean up all the places where a thread doesn't have a frame 0, and worse, actually try to do something reasonable in that case.  That would be wasted effort.  To that end, an assert here might in fact be a better solution.  In any case, it might be good to put a comment in Thread.h making it clear that GetFrameAtIndex(0) is always expected to return a valid frame.

Jim


http://reviews.llvm.org/D8574

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list