[Lldb-commits] [PATCH] Add -gdb-show and target-async option in -gdb-show command (MI)

Hafiz Abid Qadeer abidh.haq at gmail.com
Tue Mar 24 10:37:37 PDT 2015


I was wondering if there is a way to share code with -gdb-set command because there is a lot of similar code in these 2 command implementation. Otherwise ok.


================
Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:97
@@ +96,3 @@
+    const CMIUtilString strOption(pOption->GetValue());
+    ++it;
+
----------------
I think it will be useful to comment here that option can be a multi-word thing like "debug remote". So the first word is used to find the function and 2nd is used as argument to that function.

http://reviews.llvm.org/D8566

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list