[Lldb-commits] [PATCH] Force iteration over FieldDecls and RecordDecls in deterministic order.

[Sean Callanan]

The abstract interface for ExternalASTSource has a layoutRecordType() function (llvm/tools/clang/include/clang/AST/ExternalASTSource.h):

  virtual bool layoutRecordType(
      const RecordDecl *Record, uint64_t &Size, uint64_t &Alignment,
      llvm::DenseMap<const FieldDecl *, uint64_t> &FieldOffsets,
      llvm::DenseMap<const CXXRecordDecl *, CharUnits> &BaseOffsets,
      llvm::DenseMap<const CXXRecordDecl *, CharUnits> &VirtualBaseOffsets);

We're conforming to that.  I'm concerned that by changing the signature of layoutRecordType() in LLDB, you're causing our version to not be called at all.  Unless I'm missing something, this doesn't look like the right fix.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8512

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/