[Lldb-commits] [PATCH] LLDB ARM: Add support for arm-linux-gnu abi

[Ed Maste]

================
Comment at: lib/Makefile:41
@@ -40,2 +40,3 @@
 	lldbPluginABISysV_x86_64.a \
+	lldbPluginABISysV_arm.a \
 	lldbPluginABISysV_hexagon.a \
----------------
Likely ought to be in alpha order, before _ppc
(even if _hexagon is in the wrong spot)


================
Comment at: source/Initialization/InitializeLLDB.cpp:23
@@ -22,2 +22,3 @@
 #include "Plugins/ABI/SysV-x86_64/ABISysV_x86_64.h"
+#include "Plugins/ABI/SysV-x86_64/ABISysV_arm.h"
 #include "Plugins/ABI/SysV-ppc/ABISysV_ppc.h"
----------------
this path looks incorrect


================
Comment at: source/Plugins/ABI/CMakeLists.txt:2
@@ -1,2 +1,3 @@
 add_subdirectory(SysV-hexagon)
+add_subdirectory(SysV-arm)
 add_subdirectory(SysV-ppc)
----------------
alpha order

================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:20
@@ -19,1 +19,3 @@
+//TODO: Uncomment once RegisterContextLinux_arm is added.
+//#include "Plugins/Process/Utility/RegisterContextLinux_arm.h"
 #include "Plugins/Process/Utility/RegisterContextLinux_x86_64.h"
----------------
Also `//#include "Plugins/Process/Utility/RegisterContextFreeBSD_arm.h"`

================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:130
@@ -127,1 +129,3 @@
                         break;
+                    case llvm::Triple::arm:
+                        //TODO: Uncomment once RegisterContextLinux_arm is added.
----------------
please put in alpha order

================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:153
@@ -146,3 +152,3 @@
         {
             case llvm::Triple::mips64:
                 m_thread_reg_ctx_sp.reset(new RegisterContextCorePOSIX_mips64 (*this, reg_interface, m_gpregset_data, m_fpregset_data));
----------------
you need a case here for arm

http://reviews.llvm.org/D8539

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/