[Lldb-commits] [PATCH] ComputeSupportExeDirectory for Linux
Chaoren Lin
chaorenl at google.com
Mon Mar 23 19:20:07 PDT 2015
================
Comment at: source/Host/linux/HostInfoLinux.cpp:225
@@ -224,3 +224,3 @@
bool
-HostInfoLinux::ComputeSharedLibraryDirectory(FileSpec &file_spec)
{
----------------
ovyalov wrote:
> Do we need to keep this method around since HostInfoPosix::ComputeSupportExeDirectory uses GetLLDBPath(lldb::ePathTypeLLDBShlibDir..) ?
[[ http://reviews.llvm.org/D7519 | This was added by me to fix this same problem. ]] HostInfoPosix::ComputeSupportExeDirectory really wants to call HostInfoBase::ComputeSharedLibraryDirectory. I think it's more correct to move it to SupportExe because if dladdr() fails, then there should be no shared library anyway.
http://reviews.llvm.org/D8570
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list