[Lldb-commits] [PATCH] [DWARF] If linkages names are missing, use decl context to get qualified names.

[Greg Clayton]

Just fix the language compare so we aren't looking for a string "c++" and use the enum and this should be good.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:7407
@@ +7406,3 @@
+            {
+                std::string lang_name(LanguageRuntime::GetNameForLanguageType(dwarf_cu->GetLanguageType()));
+
----------------
We should add a function that can ask the language enums if they are C++ or not and use that instead of making a string.

================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:7416
@@ +7415,3 @@
+                dw_tag_t imm_parent_tag = die->GetParent()->Tag();
+                if (imm_parent_tag == DW_TAG_compile_unit && lang_name.find("c++") == 0)
+                {
----------------
Make a function that lives somewhere that is something like:

```
static bool
LanguageIsCPlusPlus (LanguageType language);

```

http://reviews.llvm.org/D8569

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/