[Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

Ilia K ki.stfu at gmail.com
Mon Mar 23 15:03:11 PDT 2015


================
Comment at: include/lldb/API/SBCommandInterpreter.h:223
@@ +222,3 @@
+    bool
+    GetPromptOnQuit() const;
+
----------------
clayborg wrote:
> You can actually take the const off of this as it does nothing when your only member is an std::shared_ptr, std::auto_ptr or just a pointer.  So please take off the const so it doesn't cause problems later. We should have no functions that return "const lldb::SB" objects.
I saw the same thing in scripts/Python/interface/SBTarget.i:
```
     bool
     IsValid() const;
```
Should we remove the 'const' here?

http://reviews.llvm.org/D8444

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list