[Lldb-commits] [PATCH] Turn off 'quit' confirmation in lldb-mi

Greg Clayton clayborg at gmail.com
Mon Mar 23 14:53:45 PDT 2015


Remove "const" as per inline comments.


================
Comment at: include/lldb/API/SBCommandInterpreter.h:223
@@ +222,3 @@
+    bool
+    GetPromptOnQuit() const;
+
----------------
You can actually take the const off of this as it does nothing when your only member is an std::shared_ptr, std::auto_ptr or just a pointer.  So please take off the const so it doesn't cause problems later. We should have no functions that return "const lldb::SB" objects.

================
Comment at: scripts/Python/interface/SBCommandInterpreter.i:150
@@ -149,1 +149,3 @@
     bool
+    GetPromptOnQuit() const;
+
----------------
Remove const per above note.

================
Comment at: source/API/SBCommandInterpreter.cpp:451
@@ +450,3 @@
+bool
+SBCommandInterpreter::GetPromptOnQuit() const
+{
----------------
remove const

http://reviews.llvm.org/D8444

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list