[Lldb-commits] [PATCH] Fetch module specification from remote process also

[Tamas Berghammer]

Address issues requested in review

BTW: Why do we prefer const char* and const StringRef& over const std::string&? (My problem with const StringRef& is that it isn't necessarily null terminated so it is expensive to convert it to a c-string while with a const char* we possibly have to check for nullptr and it is expensive to get the length of the string.)


http://reviews.llvm.org/D8547

Files:
  include/lldb/Host/common/NativeProcessProtocol.h
  include/lldb/Target/Platform.h
  include/lldb/Target/Process.h
  source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
  source/Plugins/Platform/FreeBSD/PlatformFreeBSD.h
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.h
  source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  source/Plugins/Platform/MacOSX/PlatformMacOSX.h
  source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
  source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
  source/Plugins/Platform/Windows/PlatformWindows.cpp
  source/Plugins/Platform/Windows/PlatformWindows.h
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  source/Target/Platform.cpp
  source/Target/Process.cpp
  source/Target/Target.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8547.22499.patch
Type: text/x-patch
Size: 36538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150323/954e4f00/attachment.bin>