[Lldb-commits] [PATCH] Add a missing null pointer check in CommandObjectThread.cpp.

[jingham at apple.com]

How do you get a thread that has NO frame 0?  That seems weird, we always have a register context to make frame 0...

Anyway, if you're going to do this, add it to the "thread == NULL" checks earlier on in the function so we can get out of the command with an appropriate error message. If we don't have a frame 0 we probably don't have registers so I'm not really sure how we're going to do any kind of stepping...

Jim

> On Mar 23, 2015, at 11:17 AM, Stephane Sezer <sas at cd80.net> wrote:
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D8554
> 
> Files:
>  lldb/trunk/source/Commands/CommandObjectThread.cpp
> 
> Index: lldb/trunk/source/Commands/CommandObjectThread.cpp
> ===================================================================
> --- lldb/trunk/source/Commands/CommandObjectThread.cpp
> +++ lldb/trunk/source/Commands/CommandObjectThread.cpp
> @@ -581,7 +581,7 @@
>         {
>             StackFrame *frame = thread->GetStackFrameAtIndex(0).get();
> 
> -            if (frame->HasDebugInformation ())
> +            if (frame && frame->HasDebugInformation ())
>             {
>                 new_plan_sp = thread->QueueThreadPlanForStepInRange (abort_other_plans,
>                                                                 frame->GetSymbolContext(eSymbolContextEverything).line_entry.range,
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D8554.22493.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits