[Lldb-commits] [lldb] r232805 - Fix ninja check-lldb

[Nico Weber]

Your bot is likely running a very old version of ninja.

On Fri, Mar 20, 2015 at 8:35 AM, Pavel Labath <labath at google.com> wrote:

> FWIW, I have filed a bug here <https://github.com/martine/ninja/issues/941>.
> It also contains a small test which demonstrates this behavior.
>
> On 20 March 2015 at 15:28, Zachary Turner <zturner at google.com> wrote:
>
>> +thakis
>>
>> On Fri, Mar 20, 2015 at 4:28 AM Pavel Labath <labath at google.com> wrote:
>>
>>> Author: labath
>>> Date: Fri Mar 20 06:24:36 2015
>>> New Revision: 232805
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=232805&view=rev
>>> Log:
>>> Fix ninja check-lldb
>>>
>>> Ninja apparently has issues with commands writing nul characters '\0' to
>>> stdout. When it
>>> encounters a nul character, the rest of the output is skipped (I will
>>> file a bug with ninja about
>>> that). This breaks the linux buildbot since it parses the ninja
>>> check-lldb output to get a list
>>> of failures.
>>>
>>> Recently, we have started outputting nul characters in lldb-server
>>> tests. This is probably
>>> a bug in itself, but I am not addressing that now. This is just a
>>> workaround commit, which
>>> prevents the nul characters from appearing in the output, and gets the
>>> buildbot operational again.
>>>
>>> Modified:
>>>     lldb/trunk/test/tools/lldb-server/socket_packet_pump.py
>>>
>>> Modified: lldb/trunk/test/tools/lldb-server/socket_packet_pump.py
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/
>>> lldb-server/socket_packet_pump.py?rev=232805&r1=232804&
>>> r2=232805&view=diff
>>> ============================================================
>>> ==================
>>> --- lldb/trunk/test/tools/lldb-server/socket_packet_pump.py (original)
>>> +++ lldb/trunk/test/tools/lldb-server/socket_packet_pump.py Fri Mar 20
>>> 06:24:36 2015
>>> @@ -3,6 +3,7 @@ import re
>>>  import select
>>>  import threading
>>>  import traceback
>>> +import codecs
>>>
>>>  def _handle_output_packet_string(packet_contents):
>>>      if (not packet_contents) or (len(packet_contents) < 1):
>>> @@ -16,7 +17,7 @@ def _handle_output_packet_string(packet_
>>>
>>>  def _dump_queue(the_queue):
>>>      while not the_queue.empty():
>>> -        print the_queue.get(True)
>>> +        print codecs.encode(the_queue.get(True), "string_escape")
>>>          print "\n"
>>>
>>>  class SocketPacketPump(object):
>>>
>>>
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150320/3770daa2/attachment.html>