[Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

[Hafiz Abid Qadeer]

In http://reviews.llvm.org/D8381#142039, @ki.stfu wrote:

> I don't mind about cleaning, but I disagree about CLI support in lldb-mi.




In http://reviews.llvm.org/D8381#144097, @ted wrote:

> gdb handles command line gdb and MI in one executable. I think lldb should do the same. We ship one executable, called hexagon-lldb, that is actually lldb-mi. Pass --interpreter and it runs MI, otherwise it runs the standard LLDB CLI.
>
> I'd really prefer one executable instead of two.
>
> If you go through with this, PLEASE make sure the ctrl-c handler works on all platforms. This has been a problem for us on Windows, so I want to make sure after this change it still works. Also, ctrl-c shouldn't quit MI if a target isn't running. Imagine accidentally hitting ctrl-c twice to stop a target, but the second one quits.


Ted,
Thanks for your concerns. I also faced this double ctrl-c issue in my internal branch that I build with mingw and I think I fixed it. The issue was non persistent single handling on Windows using signal API. MSVC uses SetConsoleCtrlHandler and this should not be a problem there. But I will keep an eye.

Regarding single executable, unfortunately, we already have 2. Trying to make lldb-mi also behave as lldb causes a lot of code duplication and #ifdef mess. I think it is better that it does one job and does it well.


http://reviews.llvm.org/D8381

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/