[Lldb-commits] [PATCH] Move full initialization to lldb/API

[Zachary Turner]

Actually the entire point of the CL is to move the full initializer. By
keeping it in the same place the linker has to include all those extra
symbols. It can do dead code elimination, but it's not 100% foolproof. The
reason this CL reduces LLGS binary size from 16M to 14M is precisely
because full initializer is moved out
On Thu, Mar 19, 2015 at 10:46 PM Oleksiy Vyalov <ovyalov at google.com> wrote:

> ================
> Comment at: source/API/SystemInitializerFull.cpp:1
> @@ +1,2 @@
> +//===-- SystemInitializerFull.cpp -------------------------------*- C++
> -*-===//
> +//
> ----------------
> Could we keep all initializers within source/Initialization folder?
>
> ================
> Comment at: source/Initialization/SystemLifetimeManager.cpp:68
> @@ +67,3 @@
> +    {
> +        // Don't reset the shared_ptr.  This way someone can
> theoretically call
> +        // Initialize again to re-initialize the system.
> ----------------
> s/shared_ptr/unique_ptr
>
> http://reviews.llvm.org/D8462
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150320/38ead950/attachment.html>