[Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

[Chaoren Lin]

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2253
@@ -2252,2 +2252,3 @@
 
     case 0:
+    case TRAP_TRACE:  // We receive this on single stepping.
----------------
tberghammer wrote:
> Can you add a comment why we have this case here? (I don't know. If you don't know it either then just leave it as it is now)
No clue.

================
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:400-402
@@ -400,3 +399,5 @@
     m_stop_description.clear ();
-    for (uint32_t wp_index = 0; wp_index < num_hw_watchpoints; ++wp_index)
+    uint32_t wp_index;
+    Error error = reg_ctx->GetWatchpointHitIndex(wp_index);
+    if (wp_index != LLDB_INVALID_INDEX32)
     {
----------------
tberghammer wrote:
> Please add an assert and set stop reason to some meaningful default value (e.g.: Invalid) if wp_index == LLDB_INVALID_INDEX32 as this case shouldn't happen
I think just an assert would be enough.

http://reviews.llvm.org/D8404

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/