[Lldb-commits] [PATCH] Remove IDE_MI_APP_EXIT_OK msg on exit (MI)

[Ilia K]

Remove IDE_MI_APP_EXIT_xxx messages


http://reviews.llvm.org/D8446

Files:
  tools/lldb-mi/MICmnResources.cpp
  tools/lldb-mi/MICmnResources.h
  tools/lldb-mi/MIDriverMgr.cpp

Index: tools/lldb-mi/MICmnResources.cpp
===================================================================
--- tools/lldb-mi/MICmnResources.cpp
+++ tools/lldb-mi/MICmnResources.cpp
@@ -51,9 +51,6 @@
     {IDS_DRIVERMGR_DRIVER_ERR_INIT, "Driver Manager. Driver '%s' (ID:'%s') initialise failed. %s"},
     {IDE_MEDIUMSTDERR_NAME, "Stderr"},
     {IDE_MEDIUMSTDOUT_NAME, "Stdout"},
-    {IDE_MI_APP_EXIT_OK, "Program exited OK"},
-    {IDE_MI_APP_EXIT_WITH_PROBLEM, "Program exited with a problem, see '%s' file"},
-    {IDE_MI_APP_EXIT_WITH_PROBLEM_NO_LOG, "Program exited with a problem, the application's log file '%s' was disabled"},
     {IDE_MI_APP_DESCRIPTION, "Description:\nThe Machine Interface Driver (MI Driver) is a stand alone executable\nthat either be used via "
                              "a client i.e. Eclipse or directly from the command\nline. It processes MI commands, actions those commands "
                              "using the internal\ndebugger then forms MI response formatted text which is returned to the\nclient."},
Index: tools/lldb-mi/MICmnResources.h
===================================================================
--- tools/lldb-mi/MICmnResources.h
+++ tools/lldb-mi/MICmnResources.h
@@ -65,10 +65,6 @@
     IDE_MEDIUMSTDERR_NAME,
     IDE_MEDIUMSTDOUT_NAME,
 
-    IDE_MI_APP_EXIT_OK,
-    IDE_MI_APP_EXIT_WITH_PROBLEM,
-    IDE_MI_APP_EXIT_WITH_PROBLEM_NO_LOG,
-
     IDE_MI_APP_DESCRIPTION,
     IDE_MI_APP_INFORMATION,
     IDE_MI_APP_ARG_USAGE,
Index: tools/lldb-mi/MIDriverMgr.cpp
===================================================================
--- tools/lldb-mi/MIDriverMgr.cpp
+++ tools/lldb-mi/MIDriverMgr.cpp
@@ -104,38 +104,11 @@
     // if( --m_clientUsageRefCnt > 0 )
     //  return MIstatus::success;
 
-    bool vbAppExitOk = true;
-
     ClrErrorDescription();
 
     if (!m_bInitialized)
         return MIstatus::success;
 
-    if (vbAppExitOk)
-    {
-#if _DEBUG
-        CMICmnStreamStdout::Instance().Write(MIRSRC(IDE_MI_APP_EXIT_OK)); // Both stdout and Log
-#else
-        CMICmnLog::WriteLog(MIRSRC(IDE_MI_APP_EXIT_OK)); // Just to the Log
-#endif // _DEBUG
-    }
-    else
-    {
-        CMICmnLog &rAppLog = CMICmnLog::Instance();
-        if (rAppLog.GetEnabled())
-        {
-            const CMIUtilString msg(
-                CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM), CMICmnLogMediumFile::Instance().GetFileName().c_str()));
-            CMICmnStreamStdout::Instance().Write(msg);
-        }
-        else
-        {
-            const CMIUtilString msg(
-                CMIUtilString::Format(MIRSRC(IDE_MI_APP_EXIT_WITH_PROBLEM_NO_LOG), CMICmnLogMediumFile::Instance().GetFileName().c_str()));
-            CMICmnStreamStdout::Instance().Write(msg);
-        }
-    }
-
     m_bInitialized = false;
 
     bool bOk = MIstatus::success;

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8446.22279.patch
Type: text/x-patch
Size: 2841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150319/fd473c6f/attachment.bin>