[Lldb-commits] [PATCH] implement gdb-set output-radix

Ilia K ki.stfu at gmail.com
Thu Mar 19 03:40:30 PDT 2015


================
Comment at: tools/lldb-mi/MICmdCmdVar.cpp:1060
@@ -1059,1 +1059,3 @@
             miValueTuple.Add(miValueResult7);
+        } else{
+            const CMICmnMIValueConst miValueConst4(strValue);
----------------
} newline
else newline
{

================
Comment at: tools/lldb-mi/MICmdCmdVar.cpp:1064
@@ -1060,2 +1063,3 @@
+            miValueTuple.Add(miValueResult4);
         }
         const CMICmnMIValueConst miValueConst8("0");
----------------
abidh wrote:
> This change does not seem related to the rest of the patch. It will be better to submit it separately.
agree. please create separate review for it.

http://reviews.llvm.org/D8430

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list