[Lldb-commits] [PATCH] Fix handling of CommandInterpreter's events in lldb-mi

[Ilia K]

In http://reviews.llvm.org/D8382#143198, @abidh wrote:

> > (gdb)
>
> > *stopped,reason="breakpoint-hit"
>
> > (gdb)<press Enter>
>
>
> Even with this patch, we still need to press enter once to exit as other thread has been blocked in fgets. So we will  keep handling the "quit" in MI as we do currently.


I think it's leak of lldb-mi architecture. Even if we keep "quit" handling in DoMainLoop we still need an extra Enter in case of source file with prepared commands.

> > MI: Program exited OK

> 

> 

> I think we should remove this message.


Ok. I'll do it.


================
Comment at: tools/lldb-mi/MICmnLLDBDebugger.cpp:300
@@ -299,2 +299,3 @@
     bOk = bOk && RegisterForEvent(strDbgId, CMIUtilString(lldb::SBCommandInterpreter::GetBroadcasterClass()), eventMask);
+    m_lldbDebugger.GetCommandInterpreter().GetBroadcaster().CheckInWithManager();
 
----------------
abidh wrote:
> Why we have to do this for command interpreter? 
Because CommandInterpreter object already has been created in contrast to Target/Thread/Process.

http://reviews.llvm.org/D8382

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/