[Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

Greg Clayton clayborg at gmail.com
Tue Mar 17 17:57:41 PDT 2015


Should probably init the references values to something invalid as mentioned in inlined comments.


================
Comment at: source/Host/common/NativeRegisterContext.cpp:309
@@ -308,3 +308,3 @@
 {
     return Error ("not implemented");
 }
----------------
Set "is_hit" to false?

================
Comment at: source/Host/common/NativeRegisterContext.cpp:315
@@ +314,3 @@
+{
+    return Error ("not implemented");
+}
----------------
Set "wp_index" to UINT32_MAX?

================
Comment at: source/Host/common/NativeRegisterContext.cpp:321
@@ -314,3 +320,3 @@
 {
     return Error ("not implemented");
 }
----------------
Set "is_vacant" to false?

http://reviews.llvm.org/D8404

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list