[Lldb-commits] [lldb] r232434 - Cleanup implementation of formatter for std::vector from libstdc++.

Siva Chandra sivachandra at google.com
Mon Mar 16 16:02:03 PDT 2015


Author: sivachandra
Date: Mon Mar 16 18:02:03 2015
New Revision: 232434

URL: http://llvm.org/viewvc/llvm-project?rev=232434&view=rev
Log:
Cleanup implementation of formatter for std::vector from libstdc++.

Summary: Removed unused variables and methods.

Test Plan: dotest.py -p TestDataFormatterStdVector

Reviewers: vharron

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D8368

Modified:
    lldb/trunk/examples/synthetic/gnu_libstdcpp.py

Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/synthetic/gnu_libstdcpp.py?rev=232434&r1=232433&r2=232434&view=diff
==============================================================================
--- lldb/trunk/examples/synthetic/gnu_libstdcpp.py (original)
+++ lldb/trunk/examples/synthetic/gnu_libstdcpp.py Mon Mar 16 18:02:03 2015
@@ -141,22 +141,14 @@ class StdVectorSynthProvider:
 		logger = lldb.formatters.Logger.Logger()
 		self.count = None
 		self.valobj = valobj
-		logger >> "Providing synthetic children for a map named " + str(valobj.GetName())
+		logger >> "Providing synthetic children for a vector named " + str(valobj.GetName())
 
 	def num_children(self):
-		logger = lldb.formatters.Logger.Logger()
 		if self.count == None:
 			self.count = self.num_children_impl()
 		return self.count
 
-	def is_valid_pointer(ptr,process):
-		logger = lldb.formatters.Logger.Logger()
-		error = lldb.SBError()
-		process.ReadMemory(ptr,1,error)
-		return False if error.Fail() else True
-
 	def num_children_impl(self):
-		logger = lldb.formatters.Logger.Logger()
 		try:
 			start_val = self.start.GetValueAsUnsigned(0)
 			finish_val = self.finish.GetValueAsUnsigned(0)
@@ -191,7 +183,6 @@ class StdVectorSynthProvider:
 			return 0;
 
 	def get_child_index(self,name):
-		logger = lldb.formatters.Logger.Logger()
 		try:
 			return int(name.lstrip('[').rstrip(']'))
 		except:
@@ -211,7 +202,6 @@ class StdVectorSynthProvider:
 			return None
 
 	def update(self):
-		logger = lldb.formatters.Logger.Logger()
 		# preemptively setting this to None - we might end up changing our mind later
 		self.count = None
 		try:





More information about the lldb-commits mailing list