[Lldb-commits] [lldb] r232432 - Enable TestDataFormatterStdMap on linux (libstdc++) with clang.

[Siva Chandra]

Author: sivachandra
Date: Mon Mar 16 17:45:05 2015
New Revision: 232432

URL: http://llvm.org/viewvc/llvm-project?rev=232432&view=rev
Log:
Enable TestDataFormatterStdMap on linux (libstdc++) with clang.

Summary:
This test should have been enabled along with
7181dae1248cc1b03505cca1b7c6e3dfeffefc0a, but since the test was
actually crashing, I thought it was a much deeper problem. Turns out,
all I had to do was to add "-fno-limit-debug-info" when compiling
the test case.

The test is still skipped when the testcase is compiled with GCC.

Test Plan: dotest.py -p TestDataFormatterStdMap

Reviewers: vharron

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D8364

Modified:
    lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
    lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py

Modified: lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile?rev=232432&r1=232431&r2=232432&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile (original)
+++ lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/Makefile Mon Mar 16 17:45:05 2015
@@ -4,4 +4,11 @@ CXX_SOURCES := main.cpp
 
 USE_LIBSTDCPP := 1
 
+# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
+# targets.  Other targets do not, which causes this test to fail.
+# This flag enables FullDebugInfo for all targets.
+ifneq (,$(findstring clang,$(CC)))
+  CFLAGS_EXTRAS += -fno-limit-debug-info
+endif
+
 include $(LEVEL)/Makefile.rules

Modified: lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py?rev=232432&r1=232431&r2=232432&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py (original)
+++ lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py Mon Mar 16 17:45:05 2015
@@ -24,10 +24,6 @@ class StdMapDataFormatterTestCase(TestBa
     @expectedFailureIcc   # llvm.org/pr15301: LLDB prints incorrect size of
                           # libstdc++ containers
     @skipIfFreeBSD
-    @skipIfLinux # non-core functionality, need to reenable and fix
-                 # later (DES 2014.11.07). Most likely failing because
-                 # of mis-match is version of libstdc++ supported by
-                 # the data-formatters.
     @dwarf_test
     def test_with_dwarf_and_run_command(self):
         """Test data formatter commands."""