[Lldb-commits] [PATCH] Report stopped by trace if none of the watchpoint was hit

[Chaoren Lin]

LGTM

Some nits below:


================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h:49
@@ -48,3 +48,3 @@
         Error
-        IsWatchpointVacant(uint32_t wp_index);
+        IsWatchpointVacant(uint32_t wp_index) override;
 
----------------
Is this necessary?

================
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:405
@@ +404,3 @@
+
+    // The process reported a watchpoint was hit, but we don't found the watchpoint. Assume that a
+    // stopped by trace is reported as a hardware watchpoint (happens on some linux kernels)
----------------
What Vince asked (which kernels). Also nit: grammar.

http://reviews.llvm.org/D8081

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/