[Lldb-commits] [PATCH] Allow the specification of a "mode" property on the LLDB Builder

Galina gkistanova at gmail.com
Thu Mar 12 13:10:23 PDT 2015

Assuming you would fix the small issue with the line 59.

Comment at: zorg/buildbot/builders/LLDBBuilder.py:59
@@ -58,2 +58,3 @@
-    f = getLLDBSource(f,'llvm')
+    mode = step.build.getProperty("mode") or 'update'
+    f = getLLDBSource(f,mode,'llvm')
The check will always be true and you would never get  'update', since Property is an object renderable on a slave.
What you really want here is to use the 'default' parameter. Like this:

mode = step.build.getProperty("mode", default='update')



More information about the lldb-commits mailing list