[Lldb-commits] [PATCH] Fix missing data in GetProcessInfo on linux

Tamas Berghammer tberghammer at google.com
Thu Mar 12 09:12:29 PDT 2015


In http://reviews.llvm.org/D8292#139808, @vharron wrote:

> Should ProcessInfo.GetArchitecture be const like Target?
>
> http://reviews.llvm.org/D8287


ProcessInfo.SetArchitecture don't have any logic inside it what would make it necessary.
It is possible to make it const (remove the non const version) but it would require some effort as it is used as non-const several places in the code and a simple rewrite would imply a small performance penalty also (doesn't matter here, but can matter in other places).


http://reviews.llvm.org/D8292

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list