[Lldb-commits] [PATCH] Add SBArgs to the public interface

[Jim Ingham]

My feelings in order of importance are:

1. For sure we should not be adding things to the SB API just for testing.  That's going to make for a bad API.
2. We should test everything we can test through the SB API
3. Things that are impossible to test through the SB API need some other way to test them. a) One way would be to add some SBTest headers that augment the SB API's and add stuff just for testing. They would depend on the SB API and you would SWIG & include them in the test harness.  Tests that use them would have to be marked as such since you wouldn't be able to run them against an installed lldb, but... b) Another way is to write something like C++ unit tests I kind of prefer (a) because it seems likely to me that maintaining tests based on this is less likely to depend on irrelevant implementation details of the lldb_private API's.  And it means we only have one test harness to maintain.

OTOH, in the case of SBArgs, as I said earlier I'm not totally convinced you couldn't come up with a decent reason such a thing might be useful...

Jim


http://reviews.llvm.org/D8265

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/