[Lldb-commits] [PATCH] Add code to exit the NativeProcessLinux Monitor thread on android

[Oleksiy Vyalov]

================
Comment at: source/Host/common/Host.cpp:194
@@ -176,2 +193,3 @@
         // Wait for all child processes
-#if !defined(__ANDROID__) && !defined(__ANDROID_NDK__)
+#ifdef __linux__
+        if (g_usr1_signal_thread == ::pthread_self())
----------------
I'd rather put this snippet into a separate function since it's called twice:


```
bool CheckForCancellation()
{
#ifdef __linux__
        if (g_usr1_signal_thread == ::pthread_self())
        {
            g_usr1_signal_thread = 0;
            return true;
        }
        return false;
#else
        ::pthread_testcancel ();
#endif
}
```



================
Comment at: source/Host/common/Host.cpp:262
@@ -232,3 +261,3 @@
 
                 log = lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_PROCESS);
                 if (log)
----------------
Unrelated but looks weird - could you remove this log re-initialization? It looks unnecessary.

http://reviews.llvm.org/D8205

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/