[Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

[jingham at apple.com]

I'm not responsible for the MI code or its uses, so this is only a slight opinion:

It seems to me if a client has to call "interpreter-exec" with lldb-specific commands, you are already adding lldb specific options to the MI interface, just in a messy way.  It would be cleaner to have some way to ask if the MI flavor is lldb, and then just add in the lldb options in an MI-pretty way.  Of  course, if you did it this way you should also document the extensions.

Jim

> On Mar 11, 2015, at 4:46 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D8210#138716, @abidh wrote:
> 
>> In http://reviews.llvm.org/D8210#138699, @ki.stfu wrote:
>> 
>>> In http://reviews.llvm.org/D8210#138690, @abidh wrote:
>>> 
>>>> I personally don't like using "-interpreter-exec" when there are proper MI commands available to do the job. But if start adding option/commands in lldb-mi for every options available in lldb proper then it will also get a little messy. Would it work for you to use "-interpreter-exec" as Ilia suggested above?
>>> 
>>> 
>>> I don't insist on it if these options are well-known. As I said I don't see them in description of -file-exec-and-symbols command.
>> 
>> 
>> These options are not standard MI options. ChuckR is probably trying to add in lldb-mi what he see in "Target Create" command in lldb.
> 
> 
> Then I dislike this patch. I'm not sure that we should add custom options. Is there another way to do it?
> 
> 
> http://reviews.llvm.org/D8210
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits