[Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

[Ilia K]

See my remarks below.


================
Comment at: tools/lldb-mi/MICmdCmdFile.cpp:88
@@ -78,1 +87,3 @@
+    m_setCmdArgs.Add(*(new CMICmdArgValOptionShort(m_constStrArgNamedRemotePath, false, true,
+                                                   CMICmdArgValListBase::eArgValType_StringQuoted, 1)));
     return (bOk && ParseValidateCmdOptions());
----------------
Why not eArgValType_StringQuotedNumberPath?

================
Comment at: tools/lldb-mi/MICmdCmdFile.cpp:113
@@ +112,3 @@
+    bool bPlatformName = pArgPlatformName->GetFound();
+    CMIUtilString platformName("");
+    if (bPlatformName)
----------------
Without args is better.

================
Comment at: tools/lldb-mi/MICmdCmdFile.cpp:144-153
@@ -121,1 +143,12 @@
+    }
+    if (pArgRemotePath->GetFound())
+    {
+        CMIUtilString remotePath;
+        pArgRemotePath->GetExpectedOption<CMICmdArgValString, CMIUtilString>(remotePath);
+        lldb::SBModule module = target.GetModuleAtIndex(0);
+        if (module.IsValid())
+        {
+            module.SetPlatformFileSpec(lldb::SBFileSpec(remotePath.c_str()));
+        }
     }
+    
----------------
looks like a hack.

http://reviews.llvm.org/D8210

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/