[Lldb-commits] [PATCH] Add Debugger::InitializeForLLGS to allow ref counted LLGS initialization.

Robert Flack flackr at gmail.com
Tue Mar 10 09:45:21 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: source/lldb.cpp:189-192
@@ -188,2 +188,6 @@
 #endif
+#ifndef LLDB_DISABLE_PYTHON
+        ScriptInterpreterPython::InitializePrivate();
+        OperatingSystemPython::Initialize();
+#endif
     }
----------------
tberghammer wrote:
> Please discuss with @vharron if ScriptInterpreterPython is necessary in LLGS or not (he removed it with a previous CL) and only put it back if it is used for something.
Yes, he removed it because it was calling Debugger::Terminate in configure+make builds (oddly didn't seem to in cmake) which since it didn't have any references called lldb_private::Terminate cleaning up the objects we intended to use. It does seem to be necessary at least for remote process launching, and he was okay with adding it back as long as the configure+make tests still work which I've tested.

http://reviews.llvm.org/D8183

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list