[Lldb-commits] [PATCH] Fix a comment for ValueObject::GetValueDidChange after r231526

Ilia K ki.stfu at gmail.com
Tue Mar 10 09:10:25 PDT 2015


Hi jingham,

Fix a comment for ValueObject::GetValueDidChange after r231526.

This fix was requested by @jingham.

http://reviews.llvm.org/D8206

Files:
  include/lldb/API/SBValue.h
  include/lldb/Core/ValueObject.h

Index: include/lldb/API/SBValue.h
===================================================================
--- include/lldb/API/SBValue.h
+++ include/lldb/API/SBValue.h
@@ -84,7 +84,7 @@
     ValueType
     GetValueType ();
 
-    // It will be only valid starting from the second time.
+    // If you call this on a newly created ValueObject, it will always return false. You need update its value before.
     bool
     GetValueDidChange ();
 
Index: include/lldb/Core/ValueObject.h
===================================================================
--- include/lldb/Core/ValueObject.h
+++ include/lldb/Core/ValueObject.h
@@ -649,7 +649,7 @@
     bool
     GetValueIsValid () const;
 
-    // It will be only valid starting from the second time.
+    // If you call this on a newly created ValueObject, it will always return false. You need update its value before.
     bool
     GetValueDidChange ();

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8206.21589.patch
Type: text/x-patch
Size: 903 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150310/b66bbb59/attachment.bin>


More information about the lldb-commits mailing list