[Lldb-commits] [PATCH] Initialize ProcessGDBRemoteLog for LLGS by GDBRemoteCommunication::Initialize

[Oleksiy Vyalov]

Please see my comments.


REPOSITORY
  rL LLVM

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:142
@@ +141,3 @@
+void
+GDBRemoteCommunication::Initialize()
+{
----------------
Maybe introduce ProcessGDBRemoteLog::Initialize() instead of this method?

We can put 


```
Log::Callbacks log_callbacks = {
            ProcessGDBRemoteLog::DisableLog,
            ProcessGDBRemoteLog::EnableLog,
            ProcessGDBRemoteLog::ListLogCategories
        };

        Log::RegisterLogChannel (g_name, log_callbacks);
```

inside of ProcessGDBRemoteLog::Initialize and call it from ProcessGDBRemote::Initialize and lldb-server.cpp.

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:147
@@ +146,3 @@
+
+    if (g_initialized == false)
+    {
----------------
Could you use std::call_once here?

================
Comment at: tools/lldb-server/lldb-server.cpp:11
@@ -10,2 +10,3 @@
 #include "lldb/lldb-private.h"
+#include "Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp"
 
----------------
GDBRemoteCommunication.h ?

http://reviews.llvm.org/D8186

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/